Skip to content

Fix no attributes returned with un-sampled case. #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix no attributes returned with un-sampled case. #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b30de
Fix no attributes returned without unsampled case.
zzhlogin Sep 10, 2024
70fbf71
Fix unit test.
zzhlogin Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aws-opentelemetry-distro/src/amazon/opentelemetry/distro/always_record_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,17 @@ def should_sample(
parent_context, trace_id, name, kind, attributes, links, trace_state
)
if result.decision is Decision.DROP:
result = _wrap_result_with_record_only_result(result)
result = _wrap_result_with_record_only_result(result, attributes)
return result

@override
def get_description(self) -> str:
return "AlwaysRecordSampler{" + self._root_sampler.get_description() + "}"


def _wrap_result_with_record_only_result(result: SamplingResult) -> SamplingResult:
def _wrap_result_with_record_only_result(result: SamplingResult, attributes: Attributes) -> SamplingResult:
return SamplingResult(
Decision.RECORD_ONLY,
result.attributes,
attributes,
result.trace_state,
)
2 changes: 1 addition & 1 deletion aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_always_record_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def validate_should_sample(self, root_decision: Decision, expected_decision: Dec
trace_id=0,
name="name",
kind=SpanKind.CLIENT,
attributes={},
attributes={"key": root_decision.name},
trace_state=TraceState(),
)

Expand Down
Loading