Fix: Deprecated GitHub Artifacts #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
changed the title
wangzlei
approved these changes
Feb 11, 2025
This was referenced Feb 12, 2025
yiyuan-he
added a commit
that referenced
this pull request
Feb 12, 2025
*Issue #, if available:* The previous fix did not work because `download-artifacts@v3` is also deprecated and must be updated. ``` Error: This request has been automatically failed because it uses a deprecated version of `actions/download-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ ``` Previous fix: #326 *Description of changes:* - Updating `download-artifacts@v3` to `v4`. - Also fixing syntax error for name pattern. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Github workflows are failing due to:
A downstream effect of upgrading to
v4is this version no longer allows uploading artifacts with same name.See: https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1014/files
Description of changes:
We apply the same fix in the above PR
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.