Use env variables for workflow inputs #494
Open
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
approved these changes
Oct 16, 2025
| SHA_SHORT: ${{ steps.commit.outputs.sha_short }} | ||
| run: | | ||
| echo "AWS OpenTelemetry Lambda Layer for Python version ${{ github.event.inputs.version }}-${{ steps.commit.outputs.sha_short }}" > release_notes.md | ||
| echo "AWS OpenTelemetry Lambda Layer for Python version ${VERSION}-${SHA_SHORT}" > release_notes.md |
There was a problem hiding this comment.
I don't think you need curly braces, do you?
$ AWSPulseEnablementCDK % export VERSION="asdf"
$ AWSPulseEnablementCDK % echo "abc $VERSION ${VERSION}"
abc asdf asdf
Seems to work either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Following https://docs.github.com/en/actions/reference/security/secure-use#use-an-intermediate-environment-variable, use environment variables instead of referencing Github workflow inputs directly in steps to prevent code injection.
Tested updated steps in my own fork: https://github.com/ezhang6811/aws-otel-python-instrumentation/actions/runs/18540890210
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.