Skip to content

Use env variables for workflow inputs #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: release/v0.11.x
Choose a base branch
from
+11 −4
Open

Use env variables for workflow inputs #494

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1fb640
use env vars in workflow
Oct 15, 2025
39b41d5
comment out steps for testing
Oct 15, 2025
39058e7
comment step out
Oct 15, 2025
29188cf
test fixes
Oct 15, 2025
4981c95
test fixes
Oct 15, 2025
f709304
undo commented steps for testing
Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/release-lambda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ jobs:
steps:
- name: Set up regions matrix
id: set-matrix
env:
AWS_REGIONS: ${{ github.event.inputs.aws_region }}
run: |
IFS=',' read -ra REGIONS <<< "${{ github.event.inputs.aws_region }}"
IFS=',' read -ra REGIONS <<< "$AWS_REGIONS"
MATRIX="["
for region in "${REGIONS[@]}"; do
trimmed_region=$(echo "$region" | xargs)
Expand Down Expand Up @@ -205,8 +207,11 @@ jobs:
id: commit
run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
- name: Create Release Notes
env:
VERSION: ${{ github.event.inputs.version }}
SHA_SHORT: ${{ steps.commit.outputs.sha_short }}
run: |
echo "AWS OpenTelemetry Lambda Layer for Python version ${{ github.event.inputs.version }}-${{ steps.commit.outputs.sha_short }}" > release_notes.md
echo "AWS OpenTelemetry Lambda Layer for Python version ${VERSION}-${SHA_SHORT}" > release_notes.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need curly braces, do you?

$ AWSPulseEnablementCDK % export VERSION="asdf"                   
$ AWSPulseEnablementCDK % echo "abc $VERSION ${VERSION}"
abc asdf asdf

Seems to work either way.

echo "" >> release_notes.md
echo "" >> release_notes.md
echo "See new Lambda Layer ARNs:" >> release_notes.md
Expand All @@ -218,12 +223,14 @@ jobs:
id: create_release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
VERSION: ${{ github.event.inputs.version }}
SHA_SHORT: ${{ steps.commit.outputs.sha_short }}
run: |
gh release create --target "$GITHUB_REF_NAME" \
--title "Release lambda-v${{ github.event.inputs.version }}-${{ steps.commit.outputs.sha_short }}" \
--title "Release lambda-v${VERSION}-${SHA_SHORT}" \
--notes-file release_notes.md \
--draft \
"lambda-v${{ github.event.inputs.version }}-${{ steps.commit.outputs.sha_short }}" \
"lambda-v${VERSION}-${SHA_SHORT}" \
layer_arns.tf layer.zip
echo Removing release_notes.md ...
rm -f release_notes.md
Expand Down
Loading