Skip to content

refactor(kafka): improve tests & error handling #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

refactor(kafka): improve tests & error handling #4262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5303bc
refactor(kafka): improve tests & error handling
dreamorosi Aug 4, 2025
57523ad
Merge branch 'main' into refactor/kafka_maintenance
dreamorosi Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/kafka/src/deserializer/protobuf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const deserialize = <T>(
}
} catch (error) {
throw new KafkaConsumerDeserializationError(
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${messageType}`
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${JSON.stringify(messageType)}`
);
}

Expand All @@ -64,7 +64,7 @@ const deserialize = <T>(
return decoded;
} catch {
throw new KafkaConsumerDeserializationError(
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${messageType}`
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${JSON.stringify(messageType)}`
);
}
}
Expand Down
8 changes: 6 additions & 2 deletions packages/kafka/tests/unit/consumer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,15 @@ describe('Kafka consumer', () => {
// Prepare
const handler = kafkaConsumer(
async (event) => {
const results = [];
for (const record of event.records) {
try {
return record.value;
results.push(record.value);
} catch (error) {
return error;
}
}
return results;
},
{
// @ts-expect-error - testing missing schemaStr
Expand Down Expand Up @@ -241,14 +243,16 @@ describe('Kafka consumer', () => {
// Prepare
const handler = kafkaConsumer(
async (event) => {
const results = [];
for (const record of event.records) {
try {
const { value, key } = record;
return [value, key];
results.push([value, key]);
} catch (error) {
return error;
}
}
return results;
},
{
value: {
Expand Down