Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 24, 2025

In #105 I renamed the interface from Extend to Expand, but forgot the options itself and some docs.

This is marked as a chore so it doesn't show up in the changelog for the first release. That's what we want, because it is not relevant to users just yet.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain changed the title chore(toolkit-lib): rename StackSelector option chore(toolkit-lib): rename StackSelector option to expand Feb 24, 2025
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Feb 24, 2025
@mrgrain mrgrain closed this Feb 24, 2025
auto-merge was automatically disabled February 24, 2025 16:00

Pull request was closed

@mrgrain mrgrain reopened this Feb 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (dee84c1) to head (f83f9bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   84.44%   84.82%   +0.37%     
==========================================
  Files         196      196              
  Lines       35089    35089              
  Branches     4516     4551      +35     
==========================================
+ Hits        29632    29763     +131     
+ Misses       5308     5184     -124     
+ Partials      149      142       -7     
Flag Coverage Δ
suite.unit 84.82% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit eeaf58b Feb 24, 2025
25 of 26 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/rename-stack-selector-expand branch February 24, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants