Skip to content

chore(toolkit-lib): rename StackSelector option to expand #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 1 commit into from
Feb 24, 2025
Merged

chore(toolkit-lib): rename StackSelector option to expand #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/toolkit-lib/lib/api/cloud-assembly/private/stack-assembly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class StackAssembly extends CloudAssembly implements ICloudAssemblySource
throw new ToolkitError('This app contains no stacks');
}

const extend = convertExtend(selector.extend);
const extend = expandToExtendEnum(selector.expand);
const patterns = sanitizePatterns(selector.patterns ?? []);

switch (selector.strategy) {
Expand Down Expand Up @@ -94,7 +94,7 @@ export class StackAssembly extends CloudAssembly implements ICloudAssemblySource
}
}

function convertExtend(extend?: ExpandStackSelection): CliExtendedStackSelection | undefined {
function expandToExtendEnum(extend?: ExpandStackSelection): CliExtendedStackSelection | undefined {
switch (extend) {
case ExpandStackSelection.DOWNSTREAM:
return CliExtendedStackSelection.Downstream;
Expand Down
6 changes: 3 additions & 3 deletions packages/@aws-cdk/toolkit-lib/lib/api/cloud-assembly/stack-selector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ export interface StackSelector {
patterns?: string[];

/**
* Extend the selection to upstream/downstream stacks.
* @default ExtendedStackSelection.None only select the specified/matched stacks
* Expand the selection to upstream/downstream stacks.
* @default ExpandStackSelection.None only select the specified/matched stacks
*/
extend?: ExpandStackSelection;
expand?: ExpandStackSelection;

/**
* By default, we throw an exception if the assembly contains no stacks.
Expand Down
Loading