Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 3, 2025

Actually mask the bucket name in s3 docs publishing logs. This isn't a secret, so it's not bad. The logs for the one run that did accidentally print the name have already been deleted.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 3, 2025 10:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (09ef5a0) to head (db38e63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   84.64%   84.86%   +0.21%     
==========================================
  Files         205      205              
  Lines       35648    35648              
  Branches     4591     4612      +21     
==========================================
+ Hits        30175    30251      +76     
+ Misses       5321     5247      -74     
+ Partials      152      150       -2     
Flag Coverage Δ
suite.unit 84.86% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 48244a9 Mar 3, 2025
19 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/mask-bucket-name branch March 3, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants