chore(cli): remove unused destroy options #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
reviewed
Mar 5, 2025
| * | ||
| * @default false | ||
| */ | ||
| readonly ci?: boolean; |
Contributor
There was a problem hiding this comment.
isn't this a breaking change though?
Contributor
Author
There was a problem hiding this comment.
Not in the private CDKToolkit class!
Contributor
There was a problem hiding this comment.
hmm i see now that cli/cli.ts is the only entrypoint into the cli folder. imo our private stuff should be in a private folder, but that's unrelated to your PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 85.09% 85.04% -0.06%
==========================================
Files 207 207
Lines 35723 35706 -17
Branches 4632 4620 -12
==========================================
- Hits 30400 30366 -34
- Misses 5169 5190 +21
+ Partials 154 150 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not used downstream, so let's remove them for clarity.
Note that low-level force destroy is a thing in CFN and we might reintroduce this later. It's basically about abandoning failed resources. But we currently don't support it, so let's not bother.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license