Skip to content

chore(cli): remove unused destroy options #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 1 commit into from
Mar 5, 2025
Merged

chore(cli): remove unused destroy options #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface DestroyOptions {
/**
* Change stack watcher output to CI mode.
*
* @deprecated Implement in IoHost instead
* @deprecated has no effect, please implement in IoHost instead
*/
readonly ci?: boolean;
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
stack,
deployName: stack.stackName,
roleArn: options.roleArn,
ci: options.ci,
});
await ioHost.notify(success(`\n ✅ ${chalk.blue(stack.displayName)}: ${action}ed`));
} catch (e) {
Expand Down
2 changes: 0 additions & 2 deletions packages/aws-cdk/lib/api/deployments/deploy-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,6 @@ export interface DestroyStackOptions {
sdk: SDK;
roleArn?: string;
deployName?: string;
quiet?: boolean;
ci?: boolean;
}

export async function destroyStack(options: DestroyStackOptions, { ioHost, action }: IoMessaging) {
Expand Down
5 changes: 0 additions & 5 deletions packages/aws-cdk/lib/api/deployments/deployments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,6 @@ export interface DestroyStackOptions {
stack: cxapi.CloudFormationStackArtifact;
deployName?: string;
roleArn?: string;
quiet?: boolean;
force?: boolean;
ci?: boolean;
}

export interface StackExistsOptions {
Expand Down Expand Up @@ -590,8 +587,6 @@ export class Deployments {
roleArn: executionRoleArn,
stack: options.stack,
deployName: options.deployName,
quiet: options.quiet,
ci: options.ci,
}, { ioHost: this.ioHost, action: this.action });
}

Expand Down
9 changes: 0 additions & 9 deletions packages/aws-cdk/lib/cli/cdk-toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,6 @@ export class CdkToolkit {
force: true,
roleArn: options.roleArn,
fromDeploy: true,
ci: options.ci,
});
}
return;
Expand Down Expand Up @@ -857,7 +856,6 @@ export class CdkToolkit {
stack,
deployName: stack.stackName,
roleArn: options.roleArn,
ci: options.ci,
});
success(`\n ✅ %s: ${action}ed`, chalk.blue(stack.displayName));
} catch (e) {
Expand Down Expand Up @@ -1699,13 +1697,6 @@ export interface DestroyOptions {
* Whether the destroy request came from a deploy.
*/
fromDeploy?: boolean;

/**
* Whether we are on a CI system
*
* @default false
*/
readonly ci?: boolean;
Copy link
Contributor

@kaizencc kaizencc Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a breaking change though?

Copy link
Contributor Author

@mrgrain mrgrain Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the private CDKToolkit class!

Copy link
Contributor

@kaizencc kaizencc Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i see now that cli/cli.ts is the only entrypoint into the cli folder. imo our private stuff should be in a private folder, but that's unrelated to your PR.

}

/**
Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk/lib/cli/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise<n
exclusively: args.exclusively,
force: args.force,
roleArn: args.roleArn,
ci: args.ci,
});

case 'gc':
Expand Down
Loading