fix(cdk-assets): --profile is ignored while publishing assets
#224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iliapolo
commented
Mar 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 84.91% 84.86% -0.06%
==========================================
Files 208 208
Lines 35591 35593 +2
Branches 4609 4624 +15
==========================================
- Hits 30223 30206 -17
- Misses 5214 5236 +22
+ Partials 154 151 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
commented
Mar 12, 2025
| if (options.assumeRoleArn) { | ||
| config.credentials = fromTemporaryCredentials({ | ||
| // dont forget the credentials chain. | ||
| masterCredentials: this.mainCredentials, |
Contributor
Author
There was a problem hiding this comment.
We have something similar in CDK CLI:
otaviomacedo
approved these changes
Mar 12, 2025
github-merge-queue bot
pushed a commit
to aws/aws-cdk-cli-testing
that referenced
this pull request
Mar 17, 2025
…file` (#59) Integration test for aws/aws-cdk-cli#224. Will expectedly fail until the fix in the cli repo is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We neglected to configure the main credentials when assuming the file publishing role. The main credentials are where the profile is already configured.
--profileaws-cdk-cli-testing#59Fixes #212
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license