Skip to content

fix(cdk-assets): --profile is ignored while publishing assets #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 2 commits into from
Mar 13, 2025
Merged

fix(cdk-assets): --profile is ignored while publishing assets #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8eda35
mid work
iliapolo Mar 12, 2025
f98efbc
mid work
iliapolo Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/cdk-assets/lib/aws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,24 @@ export interface Account {
export class DefaultAwsClient implements IAws {
private account?: Account;
private config: Configuration;
private readonly mainCredentials: AwsCredentialIdentityProvider;

constructor(private readonly profile?: string) {
const clientConfig: STSClientConfig = {
customUserAgent: USER_AGENT,
};

// storing the main credentials separately because
// the `config` object changes every time we assume the file publishing role.
// TODO refactor to make `config` a readonly property and avoid state mutations.
this.mainCredentials = fromNodeProviderChain({
profile: this.profile,
clientConfig,
});

this.config = {
clientConfig,
credentials: fromNodeProviderChain({
profile: this.profile,
clientConfig,
}),
credentials: this.mainCredentials,
};
}

Expand Down Expand Up @@ -228,6 +235,8 @@ export class DefaultAwsClient implements IAws {
config.region = options.region;
if (options.assumeRoleArn) {
config.credentials = fromTemporaryCredentials({
// dont forget the credentials chain.
masterCredentials: this.mainCredentials,
Copy link
Contributor Author

@iliapolo iliapolo Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have something similar in CDK CLI:

aws-cdk-cli/packages/aws-cdk/lib/api/aws-auth/sdk-provider.ts

Line 357 in 1bef263

masterCredentials: mainCredentials.credentials,

params: {
RoleArn: options.assumeRoleArn,
ExternalId: options.assumeRoleExternalId,
Expand Down