Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 3, 2025

BREAKING CHANGE: Remove the AsyncDisposable interface and dispose() method from the Toolkit class. These were previously unused and had no effect.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 3, 2025
@mrgrain mrgrain added pr/exempt-integ-test Skips the integ test steps if set. and removed p2 labels Apr 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 3, 2025 09:04
@mrgrain mrgrain closed this Apr 3, 2025
auto-merge was automatically disabled April 3, 2025 09:04

Pull request was closed

@mrgrain mrgrain reopened this Apr 3, 2025
@github-actions github-actions bot added the p2 label Apr 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (3e8359c) to head (21adca7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   85.58%   85.81%   +0.22%     
==========================================
  Files         223      223              
  Lines       37002    37002              
  Branches     4493     4501       +8     
==========================================
+ Hits        31668    31752      +84     
+ Misses       5233     5160      -73     
+ Partials      101       90      -11     
Flag Coverage Δ
suite.unit 85.81% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain disabled auto-merge April 3, 2025 10:32
@mrgrain mrgrain added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 567e998 Apr 3, 2025
31 of 32 checks passed
@mrgrain mrgrain deleted the mrgrain/fix/no-more-disposable branch April 3, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants