Skip to content

fix(toolkit-lib): remove AsyncDisposable from Toolkit #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrgrain merged 1 commit into from
Apr 3, 2025
Merged

fix(toolkit-lib): remove AsyncDisposable from Toolkit #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export interface ToolkitOptions {
/**
* The AWS CDK Programmatic Toolkit
*/
export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposable {
export class Toolkit extends CloudAssemblySourceBuilder {
/**
* The toolkit stack name used for bootstrapping resources.
*/
Expand Down Expand Up @@ -114,14 +114,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
this.ioHost = withTrimmedWhitespace(ioHost);
}

public async dispose(): Promise<void> {
// nothing to do yet
}

public async [Symbol.asyncDispose](): Promise<void> {
await this.dispose();
}

/**
* Access to the AWS SDK
*/
Expand Down
Loading