Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 3, 2025

toolkit.deploy() now returns information about the stacks it deployed.

Fixes aws/aws-cdk#33189


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team April 3, 2025 13:47
@github-actions github-actions bot added the p2 label Apr 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 3, 2025 13:47
`toolkit.deploy()` now returns information about the stacks it deployed.
@rix0rrr rix0rrr force-pushed the huijbers/deploy-return branch from 8577876 to 621d725 Compare April 3, 2025 13:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (2df3633) to head (f319a19).
Report is 202 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   86.70%   86.95%   +0.24%     
==========================================
  Files         220      220              
  Lines       35643    35648       +5     
  Branches     4344     4346       +2     
==========================================
+ Hits        30906    30999      +93     
+ Misses       4644     4550      -94     
- Partials       93       99       +6     
Flag Coverage Δ
suite.unit 86.95% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions <[email protected]>
`toolkit.deploy()` now returns information about the stacks it deployed.
@rix0rrr rix0rrr changed the base branch from main to otaviom/refactor-dry-run April 4, 2025 09:24
@rix0rrr rix0rrr changed the base branch from otaviom/refactor-dry-run to main April 4, 2025 09:24
Signed-off-by: github-actions <[email protected]>
@rix0rrr rix0rrr added the pr/exempt-integ-test Skips the integ test steps if set. label Apr 4, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 586e1b3 Apr 4, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/deploy-return branch April 4, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolkit Action: Typed return for deploy

4 participants