feat(toolkit): add a return type for toolkit.deploy()#317
Merged
aws-cdk-automation merged 7 commits intomainfrom Apr 4, 2025
Merged
feat(toolkit): add a return type for toolkit.deploy()#317aws-cdk-automation merged 7 commits intomainfrom
toolkit.deploy()#317aws-cdk-automation merged 7 commits intomainfrom
Conversation
`toolkit.deploy()` now returns information about the stacks it deployed.
rix0rrr
force-pushed
the
huijbers/deploy-return
branch
from
8577876 to
621d725
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 86.70% 86.95% +0.24%
==========================================
Files 220 220
Lines 35643 35648 +5
Branches 4344 4346 +2
==========================================
+ Hits 30906 30999 +93
+ Misses 4644 4550 -94
- Partials 93 99 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: github-actions <github-actions@github.com>
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
`toolkit.deploy()` now returns information about the stacks it deployed.
otaviomacedo
approved these changes
Apr 3, 2025
Signed-off-by: github-actions <github-actions@github.com>
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toolkit.deploy()now returns information about the stacks it deployed.Fixes aws/aws-cdk#33189
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license