chore: fix jsii publishing in a monorepo #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were cd'ing into the wrong directories.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iliapolo
reviewed
Feb 19, 2025
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
…-cli into huijbers/fix-jsii-publishing
rix0rrr
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
iliapolo
approved these changes
Feb 19, 2025
kaizencc
pushed a commit
that referenced
this pull request
Feb 19, 2025
Follow up to #71. In contrast to single package jsii publishing, our artifacts don't contain the entire repo, but rather just the compilation result of a specific package. This means that upon extraction, it needs to be placed in the specific package directory instead of the root. Currently release is failing with: ```console Error: Expected to find .jsii file in /home/runner/work/aws-cdk-cli/aws-cdk-cli/.repo/packages/@aws-cdk/cli-lib-alpha, but no such file found ``` Which is expected because it operates on an uncompiled repo. Extraction of the artifact to the correct location will overlay the repo with the compiled code. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were cd'ing into the wrong directories.
The current mechanism builds jsii packages as part of the release step. This is good because it saves time (they all get built in parallel, and it's not part of the regular build), but it's bad because if one of them fails then it'll be hard to fix and retry.
Not sure what to make of this; currently we build jsii packages both at build time and at release time, which is extra silly. We'll have to pick one.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license