refactor(cli): optimize appsync function hotswap performance #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundersc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
sundersc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
2 tasks
auto-merge was automatically disabled
February 24, 2025 18:10
Head branch was pushed to by a user without write access
sundersc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iankhou
requested changes
Feb 24, 2025
Comment on lines
+123
to
+126
| if (!functions.hasOwnProperty(sdkRequestObject.apiId)) { | ||
| functions[sdkRequestObject.apiId] = await sdk.appsync().listFunctions({ apiId: sdkRequestObject.apiId }); | ||
| } | ||
| const { functionId } = functions[sdkRequestObject.apiId].find((fn) => fn.name === physicalName) ?? {}; |
Contributor
There was a problem hiding this comment.
Can we include a unit test that validates that:
listFunctionsis called with proper params whensdkRequestObject.apiIdis not presentlistFunctionsis NOT called whensdkRequestObject.apiIdis present
?
Author
|
I'm closing the PR. Based on more testing, this approach is not going to improve the performance. If there are multiple functions in a stack, all those functions are being hotswapped at the same time, so caching is not helping here. I'm working with AppSync team to check if it is possible to support server side filtering for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize AppSync Function Hotswap Performance
This commit addresses a performance bottleneck in the AppSync function hotswap mechanism by reducing redundant API calls.
Previous Behavior:
The hotswap feature was invoking
listFunctionsseparately for each AppSync function requiring an update. This approach led to excessive API requests and potential AWS AppSync throttling.Improvements:
Resolves one of the root cause of aws-amplify/amplify-category-api#3159
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license