Skip to content

refactor(cli): optimize appsync function hotswap performance #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sundersc wants to merge 3 commits into from
Closed

refactor(cli): optimize appsync function hotswap performance #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c69314f
refactor(cli): avoid unnecessary appsync list functions api call
sundersc Feb 21, 2025
320851e
Merge branch 'main' into hotswap-functions-duplicate-calls
sundersc Feb 21, 2025
3595874
refactor(cli): cache functions based on api id
sundersc Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/aws-cdk/lib/api/hotswap/appsync-mapping-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type {
GetSchemaCreationStatusCommandOutput,
GetSchemaCreationStatusCommandInput,
FunctionConfiguration,
} from '@aws-sdk/client-appsync';
import {
type ChangeHotswapResult,
Expand All @@ -14,6 +15,8 @@ import type { SDK } from '../aws-auth';

import type { EvaluateCloudFormationTemplate } from '../evaluate-cloudformation-template';

type ApiId = string;

export async function isHotswappableAppSyncChange(
logicalId: string,
change: HotswappableChangeCandidate,
Expand Down Expand Up @@ -55,6 +58,7 @@ export async function isHotswappableAppSyncChange(
} else {
physicalName = arn;
}
const functions: Record<ApiId, FunctionConfiguration[]> = {};
ret.push({
hotswappable: true,
resourceType: change.newValue.Type,
Expand Down Expand Up @@ -116,8 +120,10 @@ export async function isHotswappableAppSyncChange(
delete sdkRequestObject.runtime;
}

const functions = await sdk.appsync().listFunctions({ apiId: sdkRequestObject.apiId });
const { functionId } = functions.find((fn) => fn.name === physicalName) ?? {};
if (!functions.hasOwnProperty(sdkRequestObject.apiId)) {
functions[sdkRequestObject.apiId] = await sdk.appsync().listFunctions({ apiId: sdkRequestObject.apiId });
}
const { functionId } = functions[sdkRequestObject.apiId].find((fn) => fn.name === physicalName) ?? {};
Comment on lines +123 to +126
Copy link
Contributor

@iankhou iankhou Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include a unit test that validates that:

  1. listFunctions is called with proper params when sdkRequestObject.apiId is not present
  2. listFunctions is NOT called when sdkRequestObject.apiId is present
    ?

// Updating multiple functions at the same time or along with graphql schema results in `ConcurrentModificationException`
await exponentialBackOffRetry(
() =>
Expand Down
Loading