fix(cli): error message when early validation failures cannot be retrieved is unclear#995
Merged
fix(cli): error message when early validation failures cannot be retrieved is unclear#995
Conversation
Clarified error message for early validation failures in deployments.
Fix error message for deployment validation failures.
gshpychka
had a problem deploying
to
integ-approval
GitHub Actions
Failure
auto-merge was automatically disabled
December 17, 2025 07:46
Head branch was pushed to by a user without write access
gshpychka
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 72 72
Lines 10023 10023
Branches 1316 1317 +1
=======================================
Hits 8779 8779
Misses 1220 1220
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
changed the title
mrgrain
changed the title
mrgrain
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified error message for early validation failures in deployments.
The current error message is confusing: it can be taken to mean that the CLI version is outdated, which is not the case.
It also mentions the CDK Toolkit stack version without any explanation - it is not clear which version it is referring to.
I also believe that saying "with the latest version of the CLI" is redundant - the error message will only appear in a sufficiently up-to-date CLI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license