Skip to content

fix(cli): error message when early validation failures cannot be retrieved is unclear #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrgrain merged 3 commits into from
Dec 17, 2025
Merged

fix(cli): error message when early validation failures cannot be retrieved is unclear #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
012f940
Improve error message for early validation failures
gshpychka Dec 15, 2025
6a36657
update test
gshpychka Dec 15, 2025
37f128a
Fix error message formatting in early-validation.ts
gshpychka Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/@aws-cdk/toolkit-lib/lib/api/deployments/early-validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export class EarlyValidationReporter implements ValidationReporter {

return `The template cannot be deployed because of early validation errors, but retrieving more details about those
errors failed (${error}). Make sure you have permissions to call the DescribeEvents API, or re-bootstrap
your environment with the latest version of the CLI (need at least version 30, current version ${currentVersion ?? 'unknown'}).`;
your environment by running 'cdk bootstrap' to update the Bootstrap CDK Toolkit stack.
Bootstrap toolkit stack version 30 or later is needed; current version: ${currentVersion ?? 'unknown'}.`;
}

let message = `ChangeSet '${changeSetName}' on stack '${stackName}' failed early validation`;
Expand Down
3 changes: 2 additions & 1 deletion packages/@aws-cdk/toolkit-lib/test/api/deployments/deploy-stack.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,8 @@ test('deployStack warns when it cannot get the events in case of early validatio
}),
).rejects.toThrow(`The template cannot be deployed because of early validation errors, but retrieving more details about those
errors failed (Error: AccessDenied). Make sure you have permissions to call the DescribeEvents API, or re-bootstrap
your environment with the latest version of the CLI (need at least version 30, current version 0).`);
your environment by running 'cdk bootstrap' to update the Bootstrap CDK Toolkit stack.
Bootstrap toolkit stack version 30 or later is needed; current version: 0.`);
});

test('deploy not skipped if template did not change but one tag removed', async () => {
Expand Down
Loading