Fix MSBuild property evaluation #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MSBuild parameters specified in `aws-lambda-tools-defaults.json` not being used with `Utilities.LookPublishAotFlag()`. Resolves aws#351.
1 task
ghost
changed the base branch from
ghost
approved these changes
Dec 19, 2024
normj
approved these changes
Dec 19, 2024
normj
added a commit
that referenced
this pull request
Dec 19, 2024
normj
added a commit
that referenced
this pull request
Dec 19, 2024
normj
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MSBuild parameters specified in
aws-lambda-tools-defaults.jsonnot being used withUtilities.LookPublishAotFlag().Taking a look at #352 I wasn't sure where to put any test that might have caught this - I'm happy to add a test for this if you can point me in the right direction.
I did test this manually against my project in Visual Studio under the debugger and it works as intended now.
Resolves #351.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.