misc: migrate to jreleaser #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
requested changes
Jul 16, 2025
Comment on lines
23
to
32
| private object EnvironmentVariables { | ||
| object JReleaser { | ||
| const val GROUP_ID = "JRELEASER_PROJECT_JAVA_GROUP_ID" | ||
| const val MAVEN_CENTRAL_USERNAME = "JRELEASER_MAVENCENTRAL_USERNAME" | ||
| const val MAVEN_CENTRAL_TOKEN = "JRELEASER_MAVENCENTRAL_TOKEN" | ||
| const val GPG_PASSPHRASE = "JRELEASER_GPG_PASSPHRASE" | ||
| const val GPG_PUBLIC_KEY = "JRELEASER_GPG_PUBLIC_KEY" | ||
| const val GPG_SECRET_KEY = "JRELEASER_GPG_SECRET_KEY" | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: Isn't everything in this file already specific to JReleaser? Seems like we could just remove the object JReleaser wrapper and keep the env vars inside the top-level object like we did with properties.
Comment on lines
146
to
155
|
|
||
| /* | ||
| Creates a placeholder JAR for the version catalog | ||
| The `version-catalog` plugin doesn't generate one because it isn't needed but JReleaser requires a jar | ||
| https://docs.gradle.org/current/userguide/version_catalogs.html#sec:version-catalog-plugin | ||
| */ | ||
| tasks.register<Jar>("versionCatalogJar") { | ||
| archiveBaseName.set("version-catalog") | ||
| from("gradle/libs.versions.toml") | ||
| } |
There was a problem hiding this comment.
Note: As discussed offline, let's try to publish this version catalog without the JAR wrapper.
ianbotsf
approved these changes
Jul 17, 2025
Comment on lines
+186
to
+192
| artifacts { | ||
| artifactOverride { | ||
| artifactId = "version-catalog" | ||
| jar = false | ||
| verifyPom = false // jreleaser doesn't understand toml packaging | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.