Skip to content

misc: migrate to jreleaser #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 18, 2025
Merged

misc: migrate to jreleaser #102

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2d41f84
feat: migrate from publish-plugin to jreleaser
0marperez Jun 24, 2025
0c2c5f0
checkpoint
0marperez Jul 1, 2025
ca18ac0
pull from main
0marperez Jul 1, 2025
5d26543
finalize
0marperez Jul 1, 2025
9ff14c4
pull from origin
0marperez Jul 1, 2025
01cd410
checkpoint
0marperez Jul 1, 2025
0a15435
misc: clean up and system properties
0marperez Jul 9, 2025
1600747
misc: self review
0marperez Jul 10, 2025
ba0cc48
properties to env vars
0marperez Jul 15, 2025
87d5f4d
self review
0marperez Jul 15, 2025
d48fce5
misc: configure version catalog in jreleaser
0marperez Jul 17, 2025
a42d596
review feedback
0marperez Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 21 additions & 26 deletions build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl/Publish.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ private object Properties {
}

private object EnvironmentVariables {
object JReleaser {
const val GROUP_ID = "JRELEASER_PROJECT_JAVA_GROUP_ID"
const val MAVEN_CENTRAL_USERNAME = "JRELEASER_MAVENCENTRAL_USERNAME"
const val MAVEN_CENTRAL_TOKEN = "JRELEASER_MAVENCENTRAL_TOKEN"
const val GPG_PASSPHRASE = "JRELEASER_GPG_PASSPHRASE"
const val GPG_PUBLIC_KEY = "JRELEASER_GPG_PUBLIC_KEY"
const val GPG_SECRET_KEY = "JRELEASER_GPG_SECRET_KEY"
}
const val GROUP_ID = "JRELEASER_PROJECT_JAVA_GROUP_ID"
const val MAVEN_CENTRAL_USERNAME = "JRELEASER_MAVENCENTRAL_USERNAME"
const val MAVEN_CENTRAL_TOKEN = "JRELEASER_MAVENCENTRAL_TOKEN"
const val GPG_PASSPHRASE = "JRELEASER_GPG_PASSPHRASE"
const val GPG_PUBLIC_KEY = "JRELEASER_GPG_PUBLIC_KEY"
const val GPG_SECRET_KEY = "JRELEASER_GPG_SECRET_KEY"
}

private val ALLOWED_PUBLICATION_NAMES = setOf(
Expand Down Expand Up @@ -113,8 +111,8 @@ fun Project.configurePublishing(repoName: String, githubOrganization: String = "
}
}

val secretKey = System.getenv(EnvironmentVariables.JReleaser.GPG_SECRET_KEY)
val passphrase = System.getenv(EnvironmentVariables.JReleaser.GPG_PASSPHRASE)
val secretKey = System.getenv(EnvironmentVariables.GPG_SECRET_KEY)
val passphrase = System.getenv(EnvironmentVariables.GPG_PASSPHRASE)

if (!secretKey.isNullOrBlank() && !passphrase.isNullOrBlank()) {
apply(plugin = "signing")
Expand Down Expand Up @@ -143,16 +141,6 @@ fun Project.configurePublishing(repoName: String, githubOrganization: String = "
}
}
}

/*
Creates a placeholder JAR for the version catalog
The `version-catalog` plugin doesn't generate one because it isn't needed but JReleaser requires a jar
https://docs.gradle.org/current/userguide/version_catalogs.html#sec:version-catalog-plugin
*/
tasks.register<Jar>("versionCatalogJar") {
archiveBaseName.set("version-catalog")
from("gradle/libs.versions.toml")
}
}

/**
Expand All @@ -163,11 +151,11 @@ fun Project.configureJReleaser() {

var missingVariables = false
listOf(
EnvironmentVariables.JReleaser.MAVEN_CENTRAL_USERNAME,
EnvironmentVariables.JReleaser.MAVEN_CENTRAL_TOKEN,
EnvironmentVariables.JReleaser.GPG_PASSPHRASE,
EnvironmentVariables.JReleaser.GPG_PUBLIC_KEY,
EnvironmentVariables.JReleaser.GPG_SECRET_KEY,
EnvironmentVariables.MAVEN_CENTRAL_USERNAME,
EnvironmentVariables.MAVEN_CENTRAL_TOKEN,
EnvironmentVariables.GPG_PASSPHRASE,
EnvironmentVariables.GPG_PUBLIC_KEY,
EnvironmentVariables.GPG_SECRET_KEY,
).forEach {
if (System.getenv(it).isNullOrBlank()) {
missingVariables = true
Expand Down Expand Up @@ -195,6 +183,13 @@ fun Project.configureJReleaser() {
active = Active.ALWAYS
url = "https://central.sonatype.com/api/v1/publisher"
stagingRepository(rootProject.layout.buildDirectory.dir("m2").get().toString())
artifacts {
artifactOverride {
artifactId = "version-catalog"
jar = false
verifyPom = false // jreleaser doesn't understand toml packaging
}
}
Comment on lines +186 to +192
Copy link
Contributor

@ianbotsf ianbotsf Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: Nice!

}
}
}
Expand All @@ -209,7 +204,7 @@ private fun isAvailableForPublication(project: Project, publication: MavenPublic
if (project.extra.has(Properties.SKIP_PUBLISHING)) shouldPublish = false

// Only publish publications with the configured group from JReleaser or everything if JReleaser group is not configured
val publishGroupName = System.getenv(EnvironmentVariables.JReleaser.GROUP_ID)
val publishGroupName = System.getenv(EnvironmentVariables.GROUP_ID)
shouldPublish = shouldPublish && (publishGroupName == null || publication.groupId.startsWith(publishGroupName))

// Validate publication name is allowed to be published
Expand Down
Loading