fix: disable redundant jreleaser signing #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinsong-cui
approved these changes
Sep 3, 2025
lauzadis
requested changes
Sep 3, 2025
| mavenCentral { | ||
| create("maven-central") { | ||
| active = Active.ALWAYS // the Maven deployer default is ALWAYS, but MavenCentral is NEVER | ||
| sign = false // Signing is done when publishing, see the 'configurePublishing' function |
There was a problem hiding this comment.
This is the default value, we don't need to set it
There was a problem hiding this comment.
I read the documentation but I think it might be wrong. When I don't set it to false I get:
org.jreleaser.model.JReleaserException: JReleaser has not been properly configured.
deploy.maven.mavenCentral.maven-central.sign is set to `true` but the signing block is not enabled
There was a problem hiding this comment.
OK we can configure it. Can you open a bug report to JReleaser?
There was a problem hiding this comment.
lauzadis
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Disables redundant artifacts signing done by JReleaser.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.