Skip to content

fix: disable redundant jreleaser signing #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

fix: disable redundant jreleaser signing #122

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b77f320
fix: disable redundant jreleaser signing
0marperez Sep 2, 2025
06da56a
Merge branch 'main' of github.com:awslabs/aws-kotlin-repo-tools into …
0marperez Sep 3, 2025
d9bed53
changes after testing
0marperez Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl/Publish.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,6 @@ fun Project.configureJReleaser() {
val requiredVariables = listOf(
EnvironmentVariables.MAVEN_CENTRAL_USERNAME,
EnvironmentVariables.MAVEN_CENTRAL_TOKEN,
EnvironmentVariables.GPG_PASSPHRASE,
EnvironmentVariables.GPG_PUBLIC_KEY,
EnvironmentVariables.GPG_SECRET_KEY,
EnvironmentVariables.GENERIC_TOKEN,
)

Expand All @@ -342,13 +339,6 @@ fun Project.configureJReleaser() {
version = providers.gradleProperty("sdkVersion").get()
}

// FIXME We're currently signing the artifacts twice. Once using the logic in configurePublishing above,
// and the second time during JReleaser's signing stage.
signing {
active = Active.ALWAYS
armored = true
}

// JReleaser requires a releaser to be configured even though we don't use it.
// https://github.com/jreleaser/jreleaser/discussions/1725#discussioncomment-10674529
release {
Expand All @@ -368,6 +358,7 @@ fun Project.configureJReleaser() {
mavenCentral {
create("maven-central") {
active = Active.ALWAYS // the Maven deployer default is ALWAYS, but MavenCentral is NEVER
sign = false // Signing is done when publishing, see the 'configurePublishing' function
Copy link
Member

@lauzadis lauzadis Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default value, we don't need to set it

Copy link
Contributor Author

@0marperez 0marperez Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the documentation but I think it might be wrong. When I don't set it to false I get:

org.jreleaser.model.JReleaserException: JReleaser has not been properly configured.
deploy.maven.mavenCentral.maven-central.sign is set to `true` but the signing block is not enabled

Copy link
Member

@lauzadis lauzadis Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK we can configure it. Can you open a bug report to JReleaser?

Copy link
Contributor Author

@0marperez 0marperez Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

@0marperez 0marperez Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jreleaser/jreleaser.github.io#94

url = "https://central.sonatype.com/api/v1/publisher"
stagingRepository(rootProject.layout.buildDirectory.dir("m2").get().toString())
artifacts {
Expand Down
Loading