misc: enable signing with JReleaser #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
commented
Sep 8, 2025
.github/actions/jreleaser/action.yml
Outdated
Comment on lines
23
to
24
| export JRELEASER_GPG_PUBLIC_KEY="${{ secrets.DUMMY_GPG_PUBLIC_KEY }}" | ||
| export JRELEASER_GPG_SECRET_KEY="${{ secrets.DUMMY_GPG_PRIVATE_KEY }}" |
There was a problem hiding this comment.
Since these are dummies, do we need to use GH Secrets or can we just export them in plain text?
xinsong-cui
approved these changes
Sep 8, 2025
0marperez
approved these changes
Sep 8, 2025
lauzadis
added a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.