Skip to content

misc: enable signing with JReleaser #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2025
Merged

misc: enable signing with JReleaser #126

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4ce551
Add signAllPublications task
lauzadis Sep 8, 2025
c353e38
Disable signing of `publications`
lauzadis Sep 8, 2025
866c165
Enable signing with JReleaser
lauzadis Sep 8, 2025
30756a4
misc: add dummy GPG keys to JReleaser action
0marperez Sep 8, 2025
9c321e6
plain text GPG keys
0marperez Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/actions/jreleaser/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,8 @@ runs:
export JRELEASER_MAVENCENTRAL_TOKEN="foo"
export JRELEASER_GENERIC_TOKEN="foo"

export JRELEASER_GPG_PASSPHRASE="foo"
export JRELEASER_GPG_PUBLIC_KEY="${{ secrets.DUMMY_GPG_PUBLIC_KEY }}"
export JRELEASER_GPG_SECRET_KEY="${{ secrets.DUMMY_GPG_PRIVATE_KEY }}"
Copy link
Member Author

@lauzadis lauzadis Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are dummies, do we need to use GH Secrets or can we just export them in plain text?


./gradlew jreleaserFullRelease --dryrun --stacktrace
29 changes: 9 additions & 20 deletions build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl/Publish.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,7 @@ fun Project.configureNexusPublishing(repoName: String, githubOrganization: Strin
}

/**
* Configure publishing for this project. This applies the `maven-publish` and `signing` plugins and configures
* the publications.
* Configure publishing for this project. This applies the `maven-publish` plugin and configures publications.
* @param repoName the repository name (e.g. `smithy-kotlin`, `aws-sdk-kotlin`, etc)
* @param githubOrganization the name of the GitHub organization that [repoName] is located in
*/
Expand Down Expand Up @@ -236,23 +235,6 @@ fun Project.configurePublishing(repoName: String, githubOrganization: String = "
}
}
}

val secretKey = System.getenv(EnvironmentVariables.GPG_SECRET_KEY)
val passphrase = System.getenv(EnvironmentVariables.GPG_PASSPHRASE)

if (!secretKey.isNullOrBlank() && !passphrase.isNullOrBlank()) {
apply(plugin = "signing")
extensions.configure<SigningExtension> {
useInMemoryPgpKeys(secretKey, passphrase)
sign(publications)
}

// FIXME - workaround for https://github.com/gradle/gradle/issues/26091
val signingTasks = tasks.withType<Sign>()
tasks.withType<AbstractPublishToMaven>().configureEach {
mustRunAfter(signingTasks)
}
}
}

tasks.withType<AbstractPublishToMaven>().configureEach {
Expand Down Expand Up @@ -312,6 +294,9 @@ fun Project.configureJReleaser() {
val requiredVariables = listOf(
EnvironmentVariables.MAVEN_CENTRAL_USERNAME,
EnvironmentVariables.MAVEN_CENTRAL_TOKEN,
EnvironmentVariables.GPG_PASSPHRASE,
EnvironmentVariables.GPG_PUBLIC_KEY,
EnvironmentVariables.GPG_SECRET_KEY,
EnvironmentVariables.GENERIC_TOKEN,
)

Expand Down Expand Up @@ -346,6 +331,11 @@ fun Project.configureJReleaser() {
version = providers.gradleProperty("sdkVersion").get()
}

signing {
active = Active.ALWAYS
armored = true
}

// JReleaser requires a releaser to be configured even though we don't use it.
// https://github.com/jreleaser/jreleaser/discussions/1725#discussioncomment-10674529
release {
Expand All @@ -365,7 +355,6 @@ fun Project.configureJReleaser() {
mavenCentral {
create("maven-central") {
active = Active.ALWAYS // the Maven deployer default is ALWAYS, but MavenCentral is NEVER
sign = false // Signing is done when publishing, see the 'configurePublishing' function
url = "https://central.sonatype.com/api/v1/publisher"
stagingRepository(rootProject.layout.buildDirectory.dir("m2").get().toString())
artifacts {
Expand Down
Loading