fix: don't use gradle to change gradle distribution URL #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Feb 6, 2025
| echo Configuring custom Gradle distribution URL with version: $gradleVersion | ||
| echo gradle wrapper --gradle-distribution-url https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip | ||
| gradle wrapper --gradle-distribution-url https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip | ||
| echo Setting distribution URL to: https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip |
There was a problem hiding this comment.
nit: distribution URL is duplicated
| run: | | ||
| cd ${{ inputs.working-directory }} | ||
| gradleVersion=$(grep "distributionUrl" ./gradle/wrapper/gradle-wrapper.properties | sed -n 's|.*gradle-\([0-9.]*\)-bin.zip|\1|p') |
There was a problem hiding this comment.
nit: typically env vars are SCREAMING_SNAKE_CASE
lauzadis
reviewed
Feb 6, 2025
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-bin.zip | ||
| distributionUrl=https://services.gradle.org/distributions/gradle-8.12-bin.zip |
There was a problem hiding this comment.
We should upgrade to 8.12.1 which is a bugfix for 8.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We were using gradle to change the gradle distribution URL. That's fine and works, but the purpose of changing the URL is to avoid gradle outages. If we use gradle to change the URL, a fresh install of gradle needs to be downloaded first, from the default distribution URL, which would fail if there's an outage.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.