Skip to content

fix: don't use gradle to change gradle distribution URL #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2025
Merged

fix: don't use gradle to change gradle distribution URL #66

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c13bbd
fix: don't use gradle to change gradle distribution URL
0marperez Feb 6, 2025
8d16355
fix: make command cross platform
0marperez Feb 6, 2025
4cf4b1e
test: different variant of previous fix
0marperez Feb 6, 2025
ec890ba
fix: pr feedback v1
0marperez Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/actions/configure-gradle/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,20 @@ runs:
shell: bash
run: |
cd ${{ inputs.working-directory }}

gradleVersion=$(grep "distributionUrl" ./gradle/wrapper/gradle-wrapper.properties | sed -n 's|.*gradle-\([0-9.]*\)-bin.zip|\1|p')
Copy link
Member

@lauzadis lauzadis Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typically env vars are SCREAMING_SNAKE_CASE


echo Configuring custom Gradle distribution URL with version: $gradleVersion
echo gradle wrapper --gradle-distribution-url https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip
gradle wrapper --gradle-distribution-url https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip
echo Setting distribution URL to: https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip
Copy link
Member

@lauzadis lauzadis Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: distribution URL is duplicated


# Detect OS and set appropriate sed option
if sed --version 2>/dev/null | grep -q "GNU sed"; then
SED_CMD="sed -i" # GNU sed (Linux)
else
SED_CMD="sed -i ''" # BSD sed (macOS)
fi

# Replace the line containing "distributionUrl" with the new distributionUrl
$SED_CMD "/distributionUrl/c\\
distributionUrl=https://d2pjps8lqszrgq.cloudfront.net/gradle-$gradleVersion-bin.zip\\
" ./gradle/wrapper/gradle-wrapper.properties
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-bin.zip
distributionUrl=https://services.gradle.org/distributions/gradle-8.12-bin.zip
Copy link
Member

@lauzadis lauzadis Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should upgrade to 8.12.1 which is a bugfix for 8.12

networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading