Skip to content

Conversation

@ianbotsf
Copy link
Contributor

Issue #, if available:

(none)

Description of changes:

Two major changes:

Kotlin Gradle Plugin errors

After upgrading to Kotlin 2.1.0, we started seeing Kotlin Gradle Plugin errors in our builds:

w: The artifact `org.jetbrains.kotlin:kotlin-compiler-embeddable` is present in the build classpath along Kotlin Gradle plugin.
This may lead to unpredictable and inconsistent behavior.
For more details, see: https://kotl.in/gradle/internal-compiler-symbols

This is being caused by our ktlint rules and plugin automatically bundling the compiler into its dependencies. This change removes kotlin-compiler-embeddable from several places where it was leaking into the buildscript classpath.

Unify ktlint versions

Previously, we hardcoded an outdated version of ktlint into our Project.configureLinting method. This change uses a build-time version file to keep the version in sync with libs.versions.toml.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ianbotsf ianbotsf requested a review from a team February 20, 2025 01:01
Copy link
Member

@lauzadis lauzadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending investigation around the style changes caused by max_line_length. If it's not possible to address the excessive newlines, I'd rather remove the max_line_length for now

@ianbotsf
Copy link
Contributor Author

ianbotsf commented Apr 9, 2025

The ktlint problems keep piling up so we're abandoning this PR for now. A new PR that just cleans up the compiler warning is up as #82.

@ianbotsf ianbotsf closed this Apr 9, 2025
@ianbotsf ianbotsf deleted the fix-ktlint-version branch April 9, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants