-
Notifications
You must be signed in to change notification settings - Fork 2
fix: stop including embedded compiler in ktlint tasks #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to take the ktlintVersion deduplication change you made?
|
Turns out this PR is broken. aws-kotlin-repo-tools builds and passes ktlint just fine but upstream projects fail to run ktlint because of the removed kotlin-compiler-embeddable transitive dependency. Got to spend some more time debugging this. |
|
OK now I think it's right. Ready for second review! |
| @@ -1,5 +1,5 @@ | |||
| [versions] | |||
| ktlint = "1.5.0" | |||
| ktlint = "1.3.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really have to downgrade our ktlint version to get this fix? If so, could we open an issue to Ktlint to fix this problem, so we are unblocked for future upgrades?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downgrade is to match the version we were previously setting explicitly in configureLinting. In that sense, it's only a downgrade for aws-kotlin-repo-tools which was previously using 1.5.0.
The 1.5.0 version actually isn't relevant to the compiler warning. The same warning happened whether we used 1.3.0 or 1.5.0. The actual problem was using the non-shadowed ktlint-cli variant.
Issue #, if available:
(none)
Description of changes:
Slimmed down version of #70 that focuses strictly on eliminating this compiler warning:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.