Skip to content

fix: stop including embedded compiler in ktlint tasks #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix: stop including embedded compiler in ktlint tasks #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a9fb64
fix: stop including embedded compiler in ktlint tasks
ianbotsf Apr 9, 2025
f4129b3
fixing bug with ktlint inclusion and adding dynamic version discovery
ianbotsf Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build-plugins/build-support/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ repositories {

dependencies {
// make our custom lint rules available to the buildscript classpath
runtimeOnly(project(":ktlint-rules"))
runtimeOnly(project(":ktlint-rules")) {
// Ensure that kotlin-compiler-embeddable isn't included in the buildscript classpath in consuming modules
exclude(group = "org.jetbrains.kotlin", module = "kotlin-compiler-embeddable")
}

implementation(libs.nexusPublishPlugin)
compileOnly(gradleApi())
implementation("aws.sdk.kotlin:s3:1.1.+")
Expand Down
3 changes: 3 additions & 0 deletions build-plugins/build-support/src/main/kotlin/aws/sdk/kotlin/gradle/dsl/CodeStyle.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ fun Project.configureLinting(lintPaths: List<String>) {
attributes {
attribute(Bundling.BUNDLING_ATTRIBUTE, objects.named(Bundling.EXTERNAL))
}

// Ensure that kotlin-compiler-embeddable isn't included in the buildscript classpath in consuming modules
exclude(group = "org.jetbrains.kotlin", module = "kotlin-compiler-embeddable")
}
}

Expand Down
4 changes: 4 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ dependencies {
attributes {
attribute(Bundling.BUNDLING_ATTRIBUTE, objects.named(Bundling.EXTERNAL))
}

// Ensure that kotlin-compiler-embeddable isn't included in the buildscript classpath
exclude(group = "org.jetbrains.kotlin", module = "kotlin-compiler-embeddable")
}

ktlint(project(":ktlint-rules"))
}

Expand Down