misc: collect artifact size metrics for private repos #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
requested changes
May 14, 2025
Comment on lines
58
to
62
| } ?: s3.listObjects { | ||
| bucket = S3_ARTIFACT_SIZE_METRICS_BUCKET | ||
| prefix = pluginConfig.bucketPrefixOverride ?: "[TEMP]private-${pluginConfig.projectRepositoryName}-staging-$identifier-" | ||
| }.contents?.map { | ||
| it.key ?: throw AwsSdkGradleException("A file from the artifact size metrics bucket is missing a key") |
There was a problem hiding this comment.
reduce duplicated code:
val prefixes = pluginConfig.bucketPrefixOverride?.let { listOf(it) } ?: listOf(
"[TEMP]${pluginConfig.projectRepositoryName}-$identifier-",
"[TEMP]private-${pluginConfig.projectRepositoryName}-staging-$identifier-"
)
prefixes.firstNotNullOfOrNull { prefix ->
...
}There was a problem hiding this comment.
Also add a comment explaining why we need to check this extra prefix
lauzadis
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Collect artifact size metrics for private repos as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.