Skip to content

misc: collect artifact size metrics for private repos #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

misc: collect artifact size metrics for private repos #88

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
451bdff
misc: collect artifact size metrics for private repos
0marperez May 13, 2025
92b3fde
feedback
0marperez May 14, 2025
5f4d29f
add comment
0marperez May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../aws/sdk/kotlin/gradle/plugins/artifactsizemetrics/CollectDelegatedArtifactSizeMetrics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ internal abstract class CollectDelegatedArtifactSizeMetrics : DefaultTask() {
prefix = pluginConfig.bucketPrefixOverride ?: "[TEMP]${pluginConfig.projectRepositoryName}-$identifier-"
}.contents?.map {
it.key ?: throw AwsSdkGradleException("A file from the artifact size metrics bucket is missing a key")
} ?: s3.listObjects {
bucket = S3_ARTIFACT_SIZE_METRICS_BUCKET
prefix = pluginConfig.bucketPrefixOverride ?: "[TEMP]private-${pluginConfig.projectRepositoryName}-staging-$identifier-"
}.contents?.map {
it.key ?: throw AwsSdkGradleException("A file from the artifact size metrics bucket is missing a key")
Copy link
Member

@lauzadis lauzadis May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce duplicated code:

        val prefixes = pluginConfig.bucketPrefixOverride?.let { listOf(it) } ?: listOf(
            "[TEMP]${pluginConfig.projectRepositoryName}-$identifier-",
            "[TEMP]private-${pluginConfig.projectRepositoryName}-staging-$identifier-"
        )

        prefixes.firstNotNullOfOrNull { prefix ->
            ...
        }

Copy link
Member

@lauzadis lauzadis May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a comment explaining why we need to check this extra prefix

}
}
}
Expand Down