Skip to content

Conversation

@gmarciani
Copy link
Contributor

@gmarciani gmarciani commented May 12, 2025

Description of changes

Fix a bug in the installation of ARM Performance Library that was causing the build image fail in isolated environments due to cookbook retrieving GCC dependencies from GCC website rather than ParallelCluster bucket.

Tests

Build images succeeded (tested in AL2 arm)

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani force-pushed the wip/mgiacomo/3131/fix-armpl-installation-0512-1 branch from 2be5672 to 90b03d5 Compare May 12, 2025 19:38
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (98c689e) to head (90b03d5).
Report is 16 commits behind head on release-3.13.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-3.13    #2942   +/-   ##
=============================================
  Coverage         75.50%   75.50%           
=============================================
  Files                23       23           
  Lines              2356     2356           
=============================================
  Hits               1779     1779           
  Misses              577      577           
Flag Coverage Δ
unittests 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmarciani gmarciani marked this pull request as ready for review May 12, 2025 21:56
@gmarciani gmarciani requested review from a team as code owners May 12, 2025 21:56
@gmarciani gmarciani enabled auto-merge (rebase) May 12, 2025 21:56
@gmarciani gmarciani disabled auto-merge May 12, 2025 21:57
… was causing the build image fail in isolated environments due to cookbook retrieving GCC dependencies from GCC website rather than ParallelCluster bucket.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3131/fix-armpl-installation-0512-1 branch from 90b03d5 to 544ee18 Compare May 12, 2025 21:57
@gmarciani gmarciani added dependencies Pull requests that update a dependency file 3.x labels May 12, 2025
@gmarciani gmarciani enabled auto-merge (rebase) May 12, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants