Skip to content

Conversation

@hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jan 7, 2026

Description of changes

Previously, the test reinstalled pcluster CLI globally with a patched version, which could interfere with other tests running in parallel.

Now the patched CLI is installed into an isolated virtual environment in /tmp, leaving the system pcluster unchanged.

Tests

I ran test_on_demand_capacity_reservation with test_build_image with all OSs in parallel with below config, test result looks good.

{%- import 'common.jinja2' as common with context -%}
{{- common.OSS_COMMERCIAL_X86.append("rocky8") or "" -}}
{{- common.OSS_COMMERCIAL_X86.append("rocky9") or "" -}}
---
test-suites:
  capacity_reservations:
    test_on_demand_capacity_reservation.py::test_on_demand_capacity_reservation:
      dimensions:
        - regions: ["us-west-2"]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: [{{ OS_X86_3 }}]
  createami:
    test_createami.py::test_build_image:
      dimensions:
        - regions: ["usw2-az1"]
          instances: ["g4dn.2xlarge"]
          schedulers: [ "slurm" ]
          oss: {{ common.OSS_COMMERCIAL_X86 }}

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Previously, the test reinstalled pcluster CLI globally with a patched
version, which could interfere with other tests running in parallel.

Now the patched CLI is installed into an isolated virtual environment
in /tmp, leaving the system pcluster unchanged.
@hehe7318 hehe7318 requested a review from a team as a code owner January 7, 2026 21:56
@hehe7318 hehe7318 added the 3.x label Jan 7, 2026
@hehe7318 hehe7318 requested a review from a team as a code owner January 7, 2026 21:56
@hehe7318 hehe7318 added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (6bd8e1d) to head (f4e9d80).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7187   +/-   ##
========================================
  Coverage    90.21%   90.21%           
========================================
  Files          183      183           
  Lines        16566    16566           
========================================
  Hits         14945    14945           
  Misses        1621     1621           
Flag Coverage Δ
unittests 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hehe7318 hehe7318 merged commit 8617a06 into aws:develop Jan 8, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants