Skip to content

Add S3 Pre-signed URL GET design document #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 27, 2025

Conversation

jencymaryjoseph
Copy link
Contributor

@jencymaryjoseph jencymaryjoseph commented Jun 24, 2025

Motivation and Context

This design document addresses a highly requested customer feature to support S3 object downloads using pre-signed URLs in AWS SDK Java v2, providing feature parity with v1.

Problem: Customers need to download S3 objects through pre-signed URLs for temporary access scenarios, but v2 SDK lacks this functionality, forcing users to either stick with v1 or implement manual HTTP client solutions.

Related to:

Modifications

  • Added comprehensive design document (docs/design/core/presignedURL-Get/Design.md)
  • Added decision log (docs/design/core/presignedURL-Get/DecisionLog.md) documenting key decisions from review meetings

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jencymaryjoseph jencymaryjoseph requested a review from a team as a code owner June 24, 2025 01:30
@RanVaknin
Copy link
Contributor

I'm not sure if adding this to the PR description will automatically close those issues:

Fixes:
GitHub Issue

#2731
GitHub Issue
#181

I think that adding an issue number in a PR, causes it to auto close. I would just make sure that it doesn't, becuase this is just a design doc and not the actual code to address those.

@jencymaryjoseph
Copy link
Contributor Author

I'm not sure if adding this to the PR description will automatically close those issues:

Fixes:
GitHub Issue
#2731
GitHub Issue
#181

I think that adding an issue number in a PR, causes it to auto close. I would just make sure that it doesn't, becuase this is just a design doc and not the actual code to address those.

The current format wouldn't auto-close the issues, but I'll change "Fixes:" to "Related to:" for clarity.
See: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@RanVaknin
Copy link
Contributor

nice! today I learned.

@joviegas joviegas enabled auto-merge June 27, 2025 15:17
Copy link

@joviegas joviegas added this pull request to the merge queue Jun 27, 2025
Merged via the queue into aws:master with commit b467a60 Jun 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants