Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 16, 2025

Issue

https://github.com/facebook/jscodeshift/releases/tag/v17.3.0

Description

Bumps jscodeshift to v17.3.0

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner June 16, 2025 18:46
Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: a421480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Jun 16, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​types/​jscodeshift@​0.12.0 ⏵ 17.3.010010073 +178100
Updatedjscodeshift@​17.1.1 ⏵ 17.3.099100100 +187100

View full report

@trivikr trivikr force-pushed the bump-jscodeshift branch from 26a09b0 to a421480 Compare June 16, 2025 19:13
@trivikr trivikr marked this pull request as draft June 16, 2025 19:16
@trivikr
Copy link
Member Author

trivikr commented Jun 16, 2025

The errors were thrown as jscodeshift upgrade updated ast-types from 0.14.2 to 0.16.1

And IdentifierKind was added for TSTypeParameter.name in https://github.com/benjamn/ast-types/releases/tag/v0.16.0 in PR benjamn/ast-types#886

@trivikr
Copy link
Member Author

trivikr commented Jun 16, 2025

Replaced by #992 where we throw explicit error instead where we expect identifier.name as string, and it's not.

@trivikr trivikr closed this Jun 16, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2025
@trivikr trivikr deleted the bump-jscodeshift branch August 6, 2025 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant