fix(tests): prevent changeset race condition in parallel tests #7183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Jul 7, 2025
tests/e2e/delete-stale-changesets.js
Outdated
| changeset.StatusReason === | ||
| `The submitted information didn't contain changes. Submit different information to create a change set.` | ||
| `The submitted information didn't contain changes. Submit different information to create a change set.` && | ||
| changeset.creationDate < new Date(Date.now() - 5 * 60 * 1000) |
There was a problem hiding this comment.
is creationDate guaranteed to be a Date?
There was a problem hiding this comment.
Haven't confirmed it, let me check
kuhe
approved these changes
Jul 7, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5881
Description
Modified
deleteStaleChangesets()to only delete changesets older than 5 minutes to prevent deletion of changesets that are actively being processed by other test processes.Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.