Skip to content

fix(tests): prevent changeset race condition in parallel tests #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

fix(tests): prevent changeset race condition in parallel tests #7183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
880c115
fix(tests): prevent changeset race condition in parallel tests
smilkuri Jul 7, 2025
63ea7e9
fix(tests): correct property name from creationDate to CreationTime
smilkuri Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/e2e/delete-stale-changesets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ exports.deleteStaleChangesets = async (client, stackName) => {
if (
changeset.Status === "FAILED" &&
changeset.StatusReason ===
`The submitted information didn't contain changes. Submit different information to create a change set.`
`The submitted information didn't contain changes. Submit different information to create a change set.` &&
changeset.creationDate < new Date(Date.now() - 5 * 60 * 1000)
Copy link
Contributor

@kuhe kuhe Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is creationDate guaranteed to be a Date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't confirmed it, let me check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's CreationTime

) {
console.log("Deleting stale changeset", changeset.ChangeSetId);
await new Promise((r) => setTimeout(r, 200));
Expand Down
Loading