Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 18, 2025

Issue

Internal JS-5905

Description

Adds an integration test which confirms checksum is not recomputed on retries

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner August 18, 2025 20:49
@trivikr trivikr marked this pull request as draft August 18, 2025 20:53
@trivikr trivikr marked this pull request as ready for review August 18, 2025 23:23
@trivikr trivikr marked this pull request as draft August 18, 2025 23:56
@trivikr
Copy link
Member Author

trivikr commented Aug 18, 2025

Although the test is successful locally, it fails in CI

 FAIL  packages/middleware-flexible-checksums/src/middleware-flexible-checksums.integ.spec.ts > middleware-flexible-checksums > S3 > putObject > retry doesn't recompute the checksum
AssertionError: expected "spy" to be called 1 times, but got 0 times
 ❯ packages/middleware-flexible-checksums/src/middleware-flexible-checksums.integ.spec.ts:153:39
    151| 
    152|         // Validate that flexibleChecksumsMiddleware is called once.
    153|         expect(mockFlexChecksCallsFn).toHaveBeenCalledTimes(1);
       |                                       ^
    154|         // Validate that retryMiddleware is called maxAttempts times.

@trivikr trivikr force-pushed the test-middleware-flexible-checksums-retry branch from 4e33329 to 9fbd398 Compare August 19, 2025 01:12
@trivikr trivikr changed the title test(middleware-flexible-checksums): retry doesn't recompute the checksum test(middleware-flexible-checksums): retry reuses the computed checksum Aug 19, 2025
@trivikr trivikr marked this pull request as ready for review August 19, 2025 02:13
@trivikr trivikr merged commit a67b561 into main Aug 19, 2025
8 checks passed
@trivikr trivikr deleted the test-middleware-flexible-checksums-retry branch August 21, 2025 19:24
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants