fix(middleware-sdk-s3): handle cross-region redirects for HeadBucket with 400 status #7313
+35
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Sep 4, 2025
Comment on lines
39
to
46
| if ( | ||
| err?.$metadata?.httpStatusCode === 301 || | ||
| // err.name === "PermanentRedirect" && --> removing the error name check, as that allows for HEAD operations (which have the 301 status code, but not the same error name) to be covered for region redirection as well | ||
| (err?.$metadata?.httpStatusCode === 400 && err?.name === "IllegalLocationConstraintException") | ||
| (err?.$metadata?.httpStatusCode === 400 && err?.name === "IllegalLocationConstraintException") || | ||
| (err?.$metadata?.httpStatusCode === 400 && | ||
| context.commandName === "HeadBucketCommand" && | ||
| err?.$response?.headers?.["x-amz-bucket-region"]) | ||
| ) { |
There was a problem hiding this comment.
Simplify this using variable names and combining the two 400 checks?
const statusCode = err?.$metadata?.httpStatusCode;
const isHeadBucket = context.commandName === "HeadBucketCommand";
const hasBucketRegionHeader = err?.$response?.headers?.["x-amz-bucket-region"];
if (
statusCode === 301 ||
(statusCode === 400 && (
err?.name === "IllegalLocationConstraintException" ||
(isHeadBucket && hasBucketRegionHeader)
))
)
kuhe
reviewed
Sep 4, 2025
| (err?.name === "IllegalLocationConstraintException" || (isHeadBucket && hasBucketRegionHeader))) | ||
| ) { | ||
| try { | ||
| const actualRegion = err.$response.headers["x-amz-bucket-region"]; |
There was a problem hiding this comment.
reuse the value from hasBucketRegionHeader. Since it isn't a boolean it should simply be called bucketRegionHeader.
kuhe
approved these changes
Sep 4, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#7304
Description
Fixes HeadBucket cross-region redirects for 400 responses for newer regions with
x-amz-bucket-regionheaderTesting
Locally
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.