-
Notifications
You must be signed in to change notification settings - Fork 634
fix(middleware-sdk-s3): handle cross-region redirects for HeadBucket with 400 status #7313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−12
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
581dfb9
fix(middleware-sdk-s3): handle cross-region redirects for HeadBucket …
smilkuri f977a7a
test(middleware-sdk-s3): add redirect test for 400 status without err…
smilkuri 439788f
chore(middleware-sdk-s3): simplify the code
smilkuri 73f68f1
chore(middleware-sdk-s3): rename and reuse the bucketRegionHeader
smilkuri 429c54e
chore(region-redirect-middleware): make bucket region header a prereq…
smilkuri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,10 @@ export function regionRedirectMiddleware(clientConfig: PreviouslyResolved): Init | |
if ( | ||
err?.$metadata?.httpStatusCode === 301 || | ||
// err.name === "PermanentRedirect" && --> removing the error name check, as that allows for HEAD operations (which have the 301 status code, but not the same error name) to be covered for region redirection as well | ||
(err?.$metadata?.httpStatusCode === 400 && err?.name === "IllegalLocationConstraintException") | ||
(err?.$metadata?.httpStatusCode === 400 && err?.name === "IllegalLocationConstraintException") || | ||
(err?.$metadata?.httpStatusCode === 400 && | ||
context.commandName === "HeadBucketCommand" && | ||
err?.$response?.headers?.["x-amz-bucket-region"]) | ||
) { | ||
try { | ||
const actualRegion = err.$response.headers["x-amz-bucket-region"]; | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify this using variable names and combining the two 400 checks?