test(clients): update payload types in client tests #7373
Merged
+70
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Sep 24, 2025
| userId: "user", | ||
| contentType: "text/plain; charset=utf-8", | ||
| inputStream: "hello world!", | ||
| inputStream: Readable.from(new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8])), |
There was a problem hiding this comment.
rather than always being set to UNSIGNED-PAYLOAD because the operation is modeled as having a data stream, in schema-serde the sigv4 signer sets a sha256 hash if the input is buffered (string or Buffer) and UNSIGNED-PAYLOAD only when it is a stream.
kuhe
commented
Sep 24, 2025
| return await client.putObject({ | ||
| Path: "foo.avi", | ||
| Body: "binary body", | ||
| Body: Readable.from(new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8])), |
kuhe
force-pushed
the
chore/client-payload-tests
branch
from
42185fb to
67f755f
Compare
kuhe
commented
Sep 24, 2025
| body: { | ||
| *[Symbol.asyncIterator]() { | ||
| // see https://docs.aws.amazon.com/AmazonS3/latest/API/RESTSelectObjectAppendix.html | ||
| yield new Uint8Array([ |
There was a problem hiding this comment.
These bytes are the actual event stream whereas the previous XML was from a generated structural example and not what is actually sent.
trivikr
approved these changes
Sep 24, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
smithy-lang/smithy-typescript#1600
preparatory compatibility fixes for Schemas
Description
Updates client integ tests to use the correct body payload types.
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?