Skip to content

fix(core/protocols): restore error fallback to UnknownError for protocols#7837

Open
siddsriv wants to merge 7 commits intomainfrom
fix/restore-unknownerror
Open

fix(core/protocols): restore error fallback to UnknownError for protocols#7837
siddsriv wants to merge 7 commits intomainfrom
fix/restore-unknownerror

Conversation

@siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Mar 10, 2026

Issue

Internal JS-6638

Description

restore error fallback for all protocols to "UnknownError" instead of "Unknown"
related fix: #7717

Testing

  • local script to get error response and core package tests pass
  • snapshot tests (diffs attached)

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts) or E2E tests.
    • It's not a feature.
  • My E2E tests are resilient to concurrent i/o.
    • I didn't write any E2E tests.
  • I added access level annotations e.g. @public, @internal tags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.
    • I didn't add any public functions.
  • Streams - how do they work?? My WebStream readers/locks are properly lifecycled. Node.js stream backpressure is handled. Error handling.
    • No streams here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv changed the title fix(core/protocols/xml): restore REST XML error fallback to UnknownError fix(core/protocols): restore REST XML error fallback to UnknownError Mar 10, 2026
@siddsriv siddsriv marked this pull request as ready for review March 10, 2026 19:14
@siddsriv siddsriv requested a review from a team as a code owner March 10, 2026 19:14
dataObject.Error?.Message ??
dataObject.message ??
dataObject.Message ??
"UnknownError";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there differences in the default error message for other protocols that were introduced in Nov '25?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should we change all Unknowns to UnknownErrors?

Copy link
Contributor Author

@siddsriv siddsriv Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i restored uniformity for this message for all protocols (smithy-client src here, what i think was the old behavior)

separate commits for each protocol, for ease of review

@siddsriv siddsriv changed the title fix(core/protocols): restore REST XML error fallback to UnknownError fix(core/protocols): restore error fallback to UnknownError for protocols Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants