fix(core/protocols): restore error fallback to UnknownError for protocols#7837
Open
fix(core/protocols): restore error fallback to UnknownError for protocols#7837
Conversation
kuhe
reviewed
Mar 10, 2026
| dataObject.Error?.Message ?? | ||
| dataObject.message ?? | ||
| dataObject.Message ?? | ||
| "UnknownError"; |
Contributor
There was a problem hiding this comment.
are there differences in the default error message for other protocols that were introduced in Nov '25?
Contributor
Author
There was a problem hiding this comment.
yes, should we change all Unknowns to UnknownErrors?
Contributor
Author
There was a problem hiding this comment.
i restored uniformity for this message for all protocols (smithy-client src here, what i think was the old behavior)
separate commits for each protocol, for ease of review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-6638
Description
restore error fallback for all protocols to "UnknownError" instead of "Unknown"
related fix: #7717
Testing
corepackage tests passChecklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.