Skip to content

fix(core/protocols): restore error fallback to UnknownError for protocols #7837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddsriv wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(core/protocols): restore error fallback to UnknownError for protocols #7837

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f4c808
fix(core/protocols/xml): restore REST XML error fallback to UnknownError
siddsriv Mar 10, 2026
749b27d
test(snapshot-testing): update S3 error snapshots for UnknownError fa…
siddsriv Mar 10, 2026
47dc20e
fix(core/protocols/json): restore JSON RPC error fallback to UnknownE…
siddsriv Mar 10, 2026
a7a2a13
fix(core/protocols/json): restore REST JSON error fallback to Unknown…
siddsriv Mar 10, 2026
ac36050
fix(core/protocols/query): restore Query error fallback to UnknownError
siddsriv Mar 10, 2026
9ff31e5
fix(core/protocols/cbor): restore Smithy RPC v2 CBOR error fallback t…
siddsriv Mar 10, 2026
0750eb2
test(core/protocols/query): update test to expect UnknownError fallback
siddsriv Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages-internal/core/src/submodules/protocols/xml/AwsRestXmlProtocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@ export class AwsRestXmlProtocol extends HttpBindingProtocol {

const ns = NormalizedSchema.of(errorSchema);
const message =
dataObject.Error?.message ?? dataObject.Error?.Message ?? dataObject.message ?? dataObject.Message ?? "Unknown";
dataObject.Error?.message ??
dataObject.Error?.Message ??
dataObject.message ??
dataObject.Message ??
"UnknownError";
Copy link
Contributor

@kuhe kuhe Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there differences in the default error message for other protocols that were introduced in Nov '25?

Copy link
Contributor Author

@siddsriv siddsriv Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should we change all Unknowns to UnknownErrors?

Copy link
Contributor Author

@siddsriv siddsriv Mar 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i restored uniformity for this message for all protocols (smithy-client src here, what i think was the old behavior)

separate commits for each protocol, for ease of review

const ErrorCtor = TypeRegistry.for(errorSchema[1]).getErrorCtor(errorSchema) ?? Error;
const exception = new ErrorCtor(message);

Expand Down
Loading