fix: upgrade S3 model manually for corrections to ReplicationRuleFilter and LifecycleRuleFilter shapes #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and LifecycleRuleFilter shapes
kstich
approved these changes
Oct 10, 2024
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Oct 10, 2024
|
Naturally, one of our own E2E tests was broken by this change. Updated to compensate. |
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Oct 11, 2024
|
0marperez
approved these changes
Oct 11, 2024
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
This update corrects two previously-incorrect S3 shapes:
ReplicationRuleFilterandLifecycleRuleFilter, both of which were modeled asunionbut are actuallystructure.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.