Skip to content

fix: upgrade S3 model manually for corrections to ReplicationRuleFilter and LifecycleRuleFilter shapes #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix: upgrade S3 model manually for corrections to ReplicationRuleFilter and LifecycleRuleFilter shapes #1439

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aed3b5d
fix: upgrade S3 model manually for corrections to ReplicationRuleFilt…
ianbotsf Oct 10, 2024
1ebf17b
correcting emoji typo
ianbotsf Oct 10, 2024
1e48bab
fix now-broken e2e test
ianbotsf Oct 10, 2024
71baa53
lint
ianbotsf Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/220eb2c9-2f5b-4ebb-bc30-901bdedc1a4c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"id": "220eb2c9-2f5b-4ebb-bc30-901bdedc1a4c",
"type": "bugfix",
"description": "⚠️ **IMPORTANT**: Update to the latest S3 model, which correctly models `ReplicationRuleFilter` and `LifecycleRuleFilter` as structures (not unions). This may cause compilation failures in existing code which references these two shapes."
}
4 changes: 2 additions & 2 deletions codegen/sdk/aws-models/s3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26084,7 +26084,7 @@
}
},
"com.amazonaws.s3#LifecycleRuleFilter": {
"type": "union",
"type": "structure",
"members": {
"Prefix": {
"target": "com.amazonaws.s3#Prefix",
Expand Down Expand Up @@ -32311,7 +32311,7 @@
}
},
"com.amazonaws.s3#ReplicationRuleFilter": {
"type": "union",
"type": "structure",
"members": {
"Prefix": {
"target": "com.amazonaws.s3#Prefix",
Expand Down
Loading