feat: provide client config property for region provider#1488
Merged
xinsong-cui merged 31 commits intov1.5-mainfrom Feb 3, 2025
Merged
feat: provide client config property for region provider#1488xinsong-cui merged 31 commits intov1.5-mainfrom
xinsong-cui merged 31 commits intov1.5-mainfrom
Conversation
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Jan 8, 2025
codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsKotlinDependency.kt
Outdated
Show resolved
Hide resolved
codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegration.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
…-sdk-kotlin into feat-region-provider
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
ianbotsf
requested changes
Jan 16, 2025
Contributor
ianbotsf
left a comment
There was a problem hiding this comment.
Correctness: Missing tests for new functionality.
codegen/aws-sdk-codegen/src/main/kotlin/aws/sdk/kotlin/codegen/AwsServiceConfigIntegration.kt
Show resolved
Hide resolved
aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/region/RegionProviderChain.kt
Outdated
Show resolved
Hide resolved
aws-runtime/aws-config/common/test/aws/sdk/kotlin/runtime/region/AwsRegionProviderChainTest.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view. |
|
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue #
#1478
Description of changes
This PR introduces
regionProviderproperty to client config in the AWS SDK for Kotlinrelated PR: smithy-lang/smithy-kotlin#1210
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.