feat: provide client config property for region provider #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xinsong-cui
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Jan 8, 2025
...otlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
ianbotsf
requested changes
Jan 13, 2025
Contributor
ianbotsf
left a comment
ianbotsf
left a comment
There was a problem hiding this comment.
Correctness: It seems we never added unit tests for RegionSupport. Let's add some and verify the codegen we expect to see.
...gen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupport.kt
Show resolved
Hide resolved
...gen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupport.kt
Show resolved
Hide resolved
...gen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupport.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
ianbotsf
requested changes
Jan 16, 2025
Contributor
ianbotsf
left a comment
ianbotsf
left a comment
There was a problem hiding this comment.
Correctness: It seems we never added unit tests for RegionSupport. Let's add some and verify the codegen we expect to see.
Correctness: We now have v1.5-main branches. Since this is a breaking change, we should update the destination branch from main to v1.5-main.
...gen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupport.kt
Show resolved
Hide resolved
...gen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupport.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Jan 30, 2025
Contributor
ianbotsf
left a comment
ianbotsf
left a comment
There was a problem hiding this comment.
Minor feedback only. Fix and ship!
...src/test/kotlin/software/amazon/smithy/kotlin/codegen/aws/customization/RegionSupportTest.kt
Outdated
Show resolved
Hide resolved
...smithy-client/common/test/aws/smithy/kotlin/runtime/client/region/RegionProviderChainTest.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xinsong-cui
commented
Jan 31, 2025
lauzadis
reviewed
Jan 31, 2025
ianbotsf
requested changes
Jan 31, 2025
ianbotsf
approved these changes
Feb 3, 2025
This comment has been minimized.
This comment has been minimized.
Affected ArtifactsSignificantly increased in size
Changed in size
|
1 task
xinsong-cui
changed the title
xinsong-cui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1478
Description of changes
Add Kotlin Coroutine dependency that will be used in aws/aws-sdk-kotlin#1488
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.